Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2040 Build System Overhaul #2041

Merged
merged 16 commits into from
Aug 2, 2023
Merged

Conversation

Rixxan
Copy link
Contributor

@Rixxan Rixxan commented Jul 27, 2023

Description

This Pull includes an overhaul of the current build system, particularly handing off of WiX based systems and a streamlined, more feature-rich installer.

Hands over the installer system to the Inno Setup installer

This allows us to provide a smaller installer file, and provide a platform to provide further expansion and options.

This system is compatible with the existing auto-updater system, and will only require minor changes to the fields already in the XML updater file.

Further edits to documentation may be required as the documentation overhaul goes forth.

As this is only the build system being altered, and post-installed functionality is not changed, this is not a public API-breaking change.

Fixes #2040

Full Changes:

  • Removes WiX and associated references
  • Renames Build-exe-and-msi.py to build.py
  • Removes Installer logic from Build.py
  • Adds inno setup and build to GitHub Actions
  • Adds EDMC ISS file for exe building
  • Adds installer.py which includes instructions to build an installer file outside of GitHub actions
  • Removes iSort in lieu of pylint/black (upcoming)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests with included alterations to Release auto build made and output confirmed.
  • Multiple install runs, clean installs, self-updates, and others made to confirm functionality
  • All PyTest tests pass

@Rixxan Rixxan self-assigned this Jul 27, 2023
@Rixxan Rixxan added code cleanup Cleaning up code devtools Developer tools related python Pull requests that update Python code github_actions Pull requests that update Github_actions code Installer Related to the Windows installer labels Jul 27, 2023
@Rixxan Rixxan linked an issue Jul 27, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@C1701D C1701D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the new Installer to install EDMC over an older version (which was installed using the old Installer) causes a separate entry in the Windows Apps list to be created. The new entry has a different name (EDMarketConnector + Version) and instead of the EDMC icon a default program icon.
Additionally uninstalling one of the two entries leaves some residual files behind (depending on which one the Start Menu entry, Uninstaller Files, AppData files etc.) and the new Installer will require a full system reboot before installing EDMC.

docs/Releasing.md Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
EDMC_Installer_Config.iss Outdated Show resolved Hide resolved
Rixxan and others added 3 commits July 29, 2023 14:53
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
Co-authored-by: Phoebe <40956085+C1701D@users.noreply.github.com>
@Rixxan Rixxan force-pushed the enhancement/2040/build-system branch from 307f452 to 9662473 Compare July 29, 2023 22:22
@C1701D C1701D merged commit 1c1b6fc into EDCD:develop Aug 2, 2023
1 check passed
@Rixxan Rixxan deleted the enhancement/2040/build-system branch August 2, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Cleaning up code devtools Developer tools related github_actions Pull requests that update Github_actions code Installer Related to the Windows installer python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Build Process
2 participants